Add codecs for DayOfWeek, Month, MonthDay, Period, Year, YearMonth#608
Closed
steverigney wants to merge 3 commits intopgjdbc:mainfrom
Closed
Add codecs for DayOfWeek, Month, MonthDay, Period, Year, YearMonth#608steverigney wants to merge 3 commits intopgjdbc:mainfrom
DayOfWeek, Month, MonthDay, Period, Year, YearMonth#608steverigney wants to merge 3 commits intopgjdbc:mainfrom
Conversation
mp911de
requested changes
Aug 28, 2023
Collaborator
mp911de
left a comment
mp911de
left a comment
There was a problem hiding this comment.
The actual code changes look quite decent. However, there's a log of refactoring changes. Please either roll these back, specifically DefaultCodecs, or move these into a separate commit for easier review.
| this.codecLookup.afterCodecAdded(); | ||
| } | ||
|
|
||
| @SuppressWarnings({"unchecked", "rawtypes"}) |
Collaborator
There was a problem hiding this comment.
What's the reason for this change? It makes the pull request almost illegible because it mixes refactorings with actual changes.
Contributor
Author
There was a problem hiding this comment.
This looks to have been introduced as part of accidental reformatting and is an oversight on my part, I have created a new commit that rolls back the formatting changes to Default Codec.
mp911de
changed the title
DayOfWeek, Month, MonthDay, Period, Year, YearMonth
Collaborator
|
Thank you for your contribution. That's merged, polished, and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that:
Issue description
New Public APIs
Additional context